Skip to content

[syntax] Add imm and deinit to syntax highlighting - #243

Merged
aahrun merged 1 commit into
modular:mainfrom
NathanSWard:nate/add-imm-and-deinit-to-syntax
Aug 3, 2026
Merged

[syntax] Add imm and deinit to syntax highlighting#243
aahrun merged 1 commit into
modular:mainfrom
NathanSWard:nate/add-imm-and-deinit-to-syntax

Conversation

@NathanSWard

@NathanSWard NathanSWard commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[syntax] Add imm and __deinit__ to syntax highlighting, and remove the deprecated __del__.

imm and __deinit__ were recently added to mojo.
We need to support syntax highlighting for them.

@NathanSWard

Copy link
Copy Markdown
Contributor Author

@DuncanMcBain - Are you able to merge this in? Github says that "merging is blocked: Code scanning is waiting for results from CodeQL for the commits cd1fb37 or c50b5f5."
I'm not too sure how to resolve this.

@DuncanMcBain

Copy link
Copy Markdown
Member

I can't do a merge either! Maybe if you try a rebase and squash? I can reapprove the PR if you do 🤔

@aahrun

aahrun commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Hey @NathanSWard - I've merged some dependabot fixes since your PR, if you update your branch we can try to get it merged ASAP and then i'll roll a release.

@aahrun

aahrun commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@NathanSWard quick question since we'll need to do an update to the changelog file too - your PR description says "add" but in the diff it looks like these are replacements. Are the old keywords gone? How should we handle that across different SDKs?

@NathanSWard
NathanSWard force-pushed the nate/add-imm-and-deinit-to-syntax branch from c50b5f5 to 49e826e Compare August 3, 2026 14:48
@NathanSWard

Copy link
Copy Markdown
Contributor Author

@aahrun - just rebased on main.
And I just added how we replaced __del__ with __deinit__.
Feel free to edit the PR title/description as you see fit 😄

@aahrun
aahrun merged commit 7661e4e into modular:main Aug 3, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants